Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #916 +/- ##
==========================================
- Coverage 91.80% 87.30% -4.51%
==========================================
Files 5 5
Lines 61 63 +2
Branches 19 19
==========================================
- Hits 56 55 -1
- Misses 5 8 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pringelmann
reviewed
Apr 15, 2026
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Axios (somehow) does not preserve entries in the config, which have an symbol as their key. So this migrates the internally used symbols to string-keys. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
pringelmann
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems Axios does not preserve entries in the request config which have a symbol-key.
So this refactors the code (see commit 3) to use string keys instead.
Commit 1 migrates the unit tests to proper tests without mocking axios.
So they are more like e2e tests (meaning we really also test integration with Axios).
Moreover I migrated them to use vitest browser mode as this library never runs in Node env but is intended for browsers.
Commit 2 only fixes the filesystem structure, we either use
tests,__tests__or next-to-code test files but nevertestfolder.